Closed michaelsauter closed 10 months ago
I find https://developer.atlassian.com/server/bitbucket/how-tos/updating-build-status-for-commits/ helpful. My understanding is:
Number 1 appears troubling to me at first glance. On the other hand in practice this could be useful to connect a build status when a commit is deployed for example by a helm umbrella repo when it deploys a commit. Key could be 'DeployTest'. Perhaps I could be convinced that this is desirable.
When shown in summary spots in the UI the build results for a commit with different keys are combined:
Having a single red build taint the overall (summarized) status feels strange to me (so perhaps I am misunderstanding the bitbucket behavior). Assuming the above is correct and deletes a pipeline run for a failed build, because perhaps it is stuck, a new build would have a new PipelineRuns derived key and this could never turn the build summary green.
Perhaps it would make sense to allow the key to be specified in ods.yaml. So that branch builds use an empty key (or git commit-sha) and integration build can use a different key.
We had a side conversation.
This PR will be helpful for distinguishing pipeline runs in umbrella repositories where the same commit triggers different builds depending on the (target) branch.
Closes #736.
Tasks:
docs/design
directory or not applicabledocs
directory or not applicablemake test
) or not applicable