search

opendevstack / ods-project-quickstarters

CAUTION! This repo is DEPRECATED. For ODS 2+, please see ods-quickstarters repository.
Apache License 2.0
10 stars 19 forks source link

import metadata: docker pull secrets are not created in an existing project - breaks oc import-image #202

Closed hugowschneider closed 5 years ago

hugowschneider commented 5 years ago

In an already existing project, the docker pull secrets are not created - when running import-metadata.sh

Proposed solution:

This if statement should be executed if the secret does not exists and not only during the creation of new projects

clemensutschig commented 5 years ago

https://github.com/opendevstack/ods-project-quickstarters/blob/master/ocp-templates/scripts/import_ocp_project_metadata.sh#L492-L494 - only creates and links in case new project

if this is NOT done .. (and you are not on the same cluster) ... https://github.com/opendevstack/ods-project-quickstarters/blob/master/ocp-templates/scripts/import_ocp_project_metadata.sh#L657

fails ...

clemensutschig commented 5 years ago

@hugowschneider - you fix this for 1.1-yes?