search

opendevstack / ods-provisioning-app

Provisioning app, which triggers project and component provisions (including Jira / Confluence / BitBucket and OCP resource creation)
Apache License 2.0
15 stars 20 forks source link

wrong exception stacktrace logging of bitbucket project key pre flight check #655

Closed stitakis closed 3 years ago

stitakis commented 3 years ago

Describe the bug Exception will be added to the log file when the BitBucketAdapter runs the pre flight project key check. In case the project key does not exists the exception will be added to the log because the HTTP response code is equal 404.

To Reproduce Create a project with a key that does not exists in Bitbucket Verify that the exception is not logged.

Expected behavior No log of an exception if the project key does not exists

Affected version (please complete the following information):

Log Output (ensure to remove any confidential information like tokens, project names, etc.

2020-12-18 09:03:03 DEBUG o.o.p.services.BitbucketAdapter - project 'BBA' was not found in bitbucket!
org.opendevstack.provision.util.exception.HttpException: Could not GET > http://bitbucket.odsbox.lan:7990/rest/api/1.0/projects/BBA  : {"errors":[{"context":null,"message":"Project BBA does not exist.","exceptionName":"com.atlassian.bitbucket.project.NoSuchProjectException"}]} Errorcode: 404
    at org.opendevstack.provision.util.rest.RestClient.execute(RestClient.java:81)
    at org.opendevstack.provision.services.BitbucketAdapter.getProject(BitbucketAdapter.java:243)
    at org.opendevstack.provision.services.BitbucketAdapter.existsProject(BitbucketAdapter.java:224)
    at org.opendevstack.provision.services.BitbucketAdapter.lambda$createProjectKeyExistsCheck$2(BitbucketAdapter.java:206)
    at java.base/java.util.function.Function.lambda$andThen$1(Unknown Source)
    at java.base/java.util.function.Function.lambda$andThen$1(Unknown Source)
    at java.base/java.util.function.Function.lambda$andThen$1(Unknown Source)
    at org.opendevstack.provision.services.BitbucketAdapter.checkCreateProjectPreconditions(BitbucketAdapter.java:180)
    at org.opendevstack.provision.controller.ProjectApiController.checkPreconditions(ProjectApiController.java:342)
    at org.opendevstack.provision.controller.ProjectApiController.addProject(ProjectApiController.java:205)
    at org.opendevstack.provision.controller.ProjectApiController$$FastClassBySpringCGLIB$$10b64f.invoke(<generated>)
    at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
    at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoi