opendevstack / ods-provisioning-app

Provisioning app, which triggers project and component provisions (including Jira / Confluence / BitBucket and OCP resource creation)
Apache License 2.0
15 stars 20 forks source link

refactor tests #659

Closed renedupont closed 3 years ago

renedupont commented 3 years ago

relates to #638

I actually started only out to get rid of the @InjectMock in the test but somehow ended up in refactoring more than that:

stitakis commented 3 years ago

@renedupont fyi... MailAdapterTest is failing in my dev env when I run all tests together. Something related to a missing dependency. I'm trying to figure out, what is the root of the problem.

stitakis commented 3 years ago

@renedupont this unit test is failing

MailAdapterTest > notifyUsersAboutProjectMailEnabled() FAILED
    org.mockito.exceptions.verification.WantedButNotInvoked at MailAdapterTest.java:55
2021-01-20 21:49:50 INFO  o.s.s.c.ThreadPoolTaskExecutor - Shutting down ExecutorService 'applicationTaskExecutor'
2021-01-20 21:49:50 INFO  o.s.c.e.EhCacheManagerFactoryBean - Shutting down EhCache CacheManager
renedupont commented 3 years ago

@stitakis I know, it is not failing locally, therefore I have a hard time fixing it 😄 , but I have an idea what the issue is (lambda expression) and will try to fix the test.