search

opendevstack / ods-provisioning-app

Provisioning app, which triggers project and component provisions (including Jira / Confluence / BitBucket and OCP resource creation)
Apache License 2.0
15 stars 20 forks source link

adds getters and setters to access class member variables #666

Closed stitakis closed 3 years ago

stitakis commented 3 years ago

partially fixes #638

stitakis commented 3 years ago

@renedupont fyi... I have disabled for this PR the finding of CodeQL, because a fix for this will be better to introduced in another branch, otherwise this PR will be even bigger. To tackle the CodeQL finding I have created this issue #667 which is high prio.

renedupont commented 3 years ago

ok! why is it happening now and not before though?

stitakis commented 3 years ago

my assumption, the tool was improved.

renedupont commented 3 years ago

but we set a specific version (v1) of that code ql analysis in the github workflow?

renedupont commented 3 years ago

ok maybe this can still get new rules without updating the actual analysis software