search

opendevstack / ods-provisioning-app

Provisioning app, which triggers project and component provisions (including Jira / Confluence / BitBucket and OCP resource creation)
Apache License 2.0
15 stars 20 forks source link

Add swagger-ui support #679

Closed stitakis closed 3 years ago

renedupont commented 3 years ago

Hey! Should this not be secured by spring security as well?

stitakis commented 3 years ago

@renedupont it is secured. If enabled, the swagger ui (/swagger-ui/index.html), which is meant in ProvApp to be used in a development environment, can only be accessed by authenticated users.

renedupont commented 3 years ago

ok I see. I guess I'd suggest to add to our improvement list the proper usage of spring profiles instead of this conditional approach. But for now seems ok, if you fix the conflicting file I can approve