Closed clemensutschig closed 2 years ago
@clemensutschig I'll take a deeper look at this, just a thought in advance, I think we should just return OK (HTTP code 200) if the process of the request was successful or otherwise an error of course. This should be enough feedback for any client.
@stitakis - let me play a little... there is something wrong in our tests as well, because they should check this (and for some reason the e2e test works ..)
depending what you send via API it will remove it (hashcode!) or not.
I am still trying to figure out why our tests don't catch this
Hurray - I have a fix :)
@clemensutschig I'll take a deeper look at this, just a thought in advance, I think we should just return OK (HTTP code 200) if the process of the request was successful or otherwise an error of course. This should be enough feedback for any client.
I left the return structure as is, wihch is also nice for a consumer 🗡️
Describe the bug
To Reproduce Steps to reproduce the behavior:
Expected behavior The project structure returned does NOT contain the deleted quickstarter anymore (only the repo which we DO NOT delete by design)
Affected version (please complete the following information):
Log Output (ensure to remove any confidential information like tokens, project names, etc. delete_componet request:
result from the api call