search

opendevstack / ods-provisioning-app

Provisioning app, which triggers project and component provisions (including Jira / Confluence / BitBucket and OCP resource creation)
Apache License 2.0
15 stars 20 forks source link

API: fix bug on remove quickstarters (deleted quickstarter still returned) - master #703

Closed clemensutschig closed 2 years ago

clemensutschig commented 2 years ago

closes #702 on master

clemensutschig commented 2 years ago

also in spirit of good doc -

the fix is in the removeQuickstarterFromProject method - which used a hash remove instead of an id-based remove. This is obviously wrong, because the quickstarter removal API only needs an id, and that's it. The reason why this did not show up in the tests is because of a bug there as well. For removal it used the full quickstarter structure retrieved from getProjects instead of a request with just the id

stitakis commented 2 years ago

@clemensutschig I'll to review today, ideally in the morning