search

opendevstack / ods-quickstarters

Contains project quickstarters (boilerplates) for Nginx, Go, Java (Spring Boot), Python (Flask), Rust (Axum), Scala (Play), TypeScript (Express), Angular, Ionic, Jupyter, RShiny - all including CI/CD integration & Jenkins build agents
Apache License 2.0
29 stars 41 forks source link

fe-ionic provision expects Protractor and fails #885

Closed cschweikert closed 1 year ago

cschweikert commented 1 year ago

The fe-ionic quickstarter uses Ionic CLI for boostraping the initial Ionic project structure. It therby always installs the latest version of Ionic. Since Ionic moved away from Protractor (see also https://ionic.io/blog/introducing-the-ionic-end-to-end-testing-reference-example), Ionic CLI doesn't create ./e2e/protractor.conf.js anymore and the following line fails: https://github.com/opendevstack/ods-quickstarters/blob/master/fe-ionic/init.sh#L90

Affected version:

bljubisic commented 1 year ago

@cschweikert What would be the desired set of actions here, do we want protractor replaced with something else, or just removed from the init.sh?

cschweikert commented 1 year ago

@bljubisic Since Ionic dropped protractor support, I would suggest to remove this part (https://github.com/opendevstack/ods-quickstarters/blob/master/fe-ionic/init.sh#L77-L91) from the init.sh.