Provide secret scanning for local setup - Githubissues

opendevstack / ods-quickstarters

Contains project quickstarters (boilerplates) for Nginx, Go, Java (Spring Boot), Python (Flask), Rust (Axum), Scala (Play), TypeScript (Express), Angular, Ionic, Jupyter, RShiny - all including CI/CD integration & Jenkins build agents

Apache License 2.0

27 stars 39 forks source link

Provide secret scanning for local setup #963

Closed serverhorror closed 10 months ago

serverhorror commented 10 months ago

Description here ...

Closes #... Fixes #...

Tasks:

[x] Updated documentation in docs/modules/... directory
[ ] Ran tests in <quickstarter>/testdata directory

serverhorror commented 10 months ago

There we go, as dicussed in our meeting.

This:

starts out with gitleaks
has no impact on current usage (if not activated by the user)
gives us the structure
if everything works out we have a central partial that will allow to update the docs in a central place

Anything that I'm missing?

serverhorror commented 10 months ago

Hello,

@michaelsauter, @oalyman, @metmajer, @nichtraunzer, @bljubisic, @buegelbeatz, @tbugfinder, @sino92, @clemensutschig, @sklingel

Your reviews are missing. Can this be merged? Are there any tests that need to run for this to be accepted?

serverhorror commented 10 months ago

Sorry wasn't aware you're waiting for approval from everyone :) This is great, please go ahead!

I am not, I will never merge my own PRs. Apart from that: I don't even have the technical permissions.

Whoever merges, merges :)

serverhorror commented 10 months ago

@metmajer, @nichtraunzer, @tbugfinder, @bljubisic, @sklingel, @sino92, @buegelbeatz, @clemensutschig

Ping!

Your approvals are still missing, or you can merge if you are happy with the existing approvals.