search

opendiffy / diffy

Other
1.25k stars 142 forks source link

Censor pii #52

Closed cmoore-threatmetrix closed 2 years ago

cmoore-threatmetrix commented 4 years ago

Added parsing for key=value based inputs and outputs. This is currently picked after JSON and before HTML.

Added sensitiveParameters option to allow it to automatically redact various top-level parameters from the request. This is useful for protecting the privacy of user data that has gone through diffy. Users can "opt-out" of collecting various parameters on the command line and they will be replaced with "XXXXXXX" of the same length if string, or "redacted" if structured.

codecov-commenter commented 4 years ago

Codecov Report

Merging #52 into master will increase coverage by 0.88%. The diff coverage is 93.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   68.19%   69.07%   +0.88%     
==========================================
  Files          33       33              
  Lines         918      954      +36     
  Branches       23       32       +9     
==========================================
+ Hits          626      659      +33     
- Misses        292      295       +3
Impacted Files Coverage Δ
src/main/scala/ai/diffy/lifter/HttpLifter.scala 91.66% <92.68%> (-0.65%) :arrow_down:
src/main/scala/ai/diffy/DiffyServiceModule.scala 100.00% <100.00%> (ø)
...ain/scala/ai/diffy/proxy/HttpDifferenceProxy.scala 68.42% <100.00%> (+1.75%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update caf1c4b...f51fac7. Read the comment docs.