search

opendilab / GoBigger-Challenge-2021

Interested in multi-agents? The 1st Go-Bigger Multi-Agent Decision Intelligence Challenge is coming and a big bonus is waiting for you!
Apache License 2.0
195 stars 33 forks source link

There may be a mistake [I'm not sure] #5

Closed yizhangliu closed 2 years ago

yizhangliu commented 2 years ago

Thanks for your work. There may be a mistake in function _to_raw_action(act: int).

    if direction == 0:
        x, y = 0, 1
    elif direction == 1:
        x, y = 0, -1

Maybe it should be:

    if direction == 0:
        x, y = 0, -1
    elif direction == 1:
        x, y = 0, 1
mingzhang96 commented 2 years ago

Thanks for your question!

I don't think it is a mistake. The correspondence between direction and (x, y) is not important, you just need to ensure one-to-one correspondence. Hope this helps!