opendilab / GoBigger

[ICLR 2023] Come & try Decision-Intelligence version of "Agar"! Gobigger could also help you with multi-agent decision intelligence study.
https://gobigger.readthedocs.io/en/latest/
Apache License 2.0
457 stars 34 forks source link

fix SporeBall in step #4

Closed mingzhang96 closed 2 years ago

mingzhang96 commented 2 years ago

However, the last elif will not work because we don't add any SporeBall in moving_balls. But it is still necessary to leave SporeBall in server.deal_with_collision() to make it easy to add sporeball in the future.

codecov[bot] commented 2 years ago

Codecov Report

Merging #4 (9295098) into main (92f3724) will increase coverage by 0.03%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   85.77%   85.81%   +0.03%     
==========================================
  Files          52       52              
  Lines        3108     3108              
==========================================
+ Hits         2666     2667       +1     
+ Misses        442      441       -1     
Flag Coverage Δ
unittests 85.81% <0.00%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gobigger/server/server.py 68.34% <0.00%> (+0.45%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 92f3724...9295098. Read the comment docs.