opendistro-for-elasticsearch / alerting

📟 Open Distro Alerting Plugin
https://opendistro.github.io/for-elasticsearch/features/alerting.html
Apache License 2.0
279 stars 80 forks source link

Refactor Trigger to be an interface and update Monitor #372

Closed qreshi closed 3 years ago

qreshi commented 3 years ago

Issue #, if available:

Description of changes: For Document-Level Alerting, a new Trigger type will be introduced. To scale for this change, Trigger was refactored to be an interface. The current Trigger is now referred to as TraditionalTrigger.

Monitor now has monitor_types where the current Monitor is referred to as a traditional_monitor and uses TraditionalTriggers. The aggregation/multi-alert Alerting behavior will be available in aggregation_monitors which will use AggregationTriggers. These names are not set in stone, it was mostly to differentiate the implementations.

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

lezzago commented 3 years ago

We need to remember to update the schema version once we are merging into main