Closed qreshi closed 3 years ago
Rebased with the head of the dev branch and updated the PR to integrate with the changes. The MonitorRunner for Aggregation Monitor is now functional in generating new alerts and deduping but there are still some things missing:
after_key
is present and being used but the next page is empty since all the results were shown on the first page (leading to an empty run in the do-while loop of the runner)triggerResults
needs to be continually appended to across the do-while iterations so it is complete by the end of the run (for not it is just reset each iteration)actionRunResults
and reindexed/updated at the end of the runPER_EXECUTION
actions need to be lifted out of the do-while since the Actions should not be executed once per iteration of the do-while loop but instead be done once per execution
PER_EXECUTION
have them all loaded into the action context for execution There are also things like missing circuit breakers and integration tests but the above was mostly to capture bugs/misbehaving functionality.
Merging in now as the changes were discussed with @rishabhmaurya
Issue #, if available:
Description of changes:
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.