opendistro-for-elasticsearch / alerting

📟 Open Distro Alerting Plugin
https://opendistro.github.io/for-elasticsearch/features/alerting.html
Apache License 2.0
279 stars 80 forks source link

Porting CVE fixes to 1.13 #400

Closed AWSHurneyt closed 2 years ago

AWSHurneyt commented 2 years ago

Issue #, if available:

Description of changes:

  1. Updating dependencies based on PRs #393 and #395.
  2. Fixing ktlint errors.

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

peterzhuamazon commented 2 years ago

Hi @CEHENKLE @bbarani I enabled the actions of this repo for @lezzago to run checks. Once completed @lezzago should let me know so I can disable the actions again.

Thanks.

codecov[bot] commented 2 years ago

Codecov Report

Merging #400 (2e37d97) into opendistro-1.13 (0491dfe) will increase coverage by 0.39%. The diff coverage is 84.70%.

:exclamation: Current head 2e37d97 differs from pull request most recent head 0d0cdff. Consider uploading reports for the commit 0d0cdff to get more accurate results

@@                  Coverage Diff                  @@
##             opendistro-1.13     #400      +/-   ##
=====================================================
+ Coverage              79.35%   79.74%   +0.39%     
- Complexity               203      212       +9     
=====================================================
  Files                    151      151              
  Lines                   5323     5327       +4     
  Branches                 698      700       +2     
=====================================================
+ Hits                    4224     4248      +24     
+ Misses                   725      705      -20     
  Partials                 374      374              
Impacted Files Coverage Δ
...icsearch/alerting/action/AcknowledgeAlertAction.kt 50.00% <ø> (-16.67%) :arrow_down:
...csearch/alerting/action/DeleteDestinationAction.kt 50.00% <ø> (-16.67%) :arrow_down:
...asticsearch/alerting/action/DeleteMonitorAction.kt 50.00% <ø> (-16.67%) :arrow_down:
...sticsearch/alerting/action/ExecuteMonitorAction.kt 50.00% <ø> (-16.67%) :arrow_down:
...orelasticsearch/alerting/action/GetAlertsAction.kt 50.00% <ø> (-16.67%) :arrow_down:
...ticsearch/alerting/action/GetDestinationsAction.kt 50.00% <ø> (-16.67%) :arrow_down:
...ticsearch/alerting/action/GetEmailAccountAction.kt 50.00% <ø> (-16.67%) :arrow_down:
...asticsearch/alerting/action/GetEmailGroupAction.kt 50.00% <ø> (-16.67%) :arrow_down:
...relasticsearch/alerting/action/GetMonitorAction.kt 50.00% <ø> (-16.67%) :arrow_down:
...icsearch/alerting/action/IndexDestinationAction.kt 50.00% <ø> (-16.67%) :arrow_down:
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0491dfe...0d0cdff. Read the comment docs.

lezzago commented 2 years ago

@peterzhuamazon can you please disable the "Build Alerting with JDK 12" check. That check is not needed as we are buying it with JDK 14 only now

peterzhuamazon commented 2 years ago

@lezzago I have removed the requirement of this test. Thanks.

peterzhuamazon commented 2 years ago

Disable actions again as all the checks passed and no need to run actions anymore. Thanks.

AWSHurneyt commented 2 years ago

To confirm, these changes successfully built locally.