search

opendistro-for-elasticsearch / anomaly-detection-kibana-plugin

A Kibana plugin providing visualizations for anomaly detection in Open Distro.
https://opendistro.github.io/
Apache License 2.0
44 stars 18 forks source link

Add 'No data' state for historical detectors #364

Closed ohltyler closed 3 years ago

ohltyler commented 3 years ago

Issue #, if available: #361

Description of changes:

This PR adds a 'No data' state to the historical detectors, to make it more clear to the user when a historical detector's detection date range doesn't return any results / no data to aggregate over. Previously, this error was captured under the vague 'Unexpected failure' detector state, and provided no actionable steps for the user to try to fix it.

Specific changes:

  1. Adds the 'No data' state to the list of detector states, only displays specifically for historical detectors
  2. Adds a callout with a button to edit the historical detector when in the 'No data' state
  3. Adds corresponding UT

Screenshots: image

image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ohltyler commented 3 years ago

Will confirm with UX on the changes before merging.