search

opendistro-for-elasticsearch / k-NN

🆕 A machine learning plugin which supports an approximate k-NN search algorithm for Open Distro.
https://opendistro.github.io/
Apache License 2.0
277 stars 55 forks source link

Change "space" parameter to "space_type" for custom scoring #232

Closed jmazanec15 closed 4 years ago

jmazanec15 commented 4 years ago

Issue #, if available:

Description of changes: For Approximate k-NN search, we use "space_type" to specify the space for the index. For custom scoring search, we use the parameter "space". To maintain consistency and prevent confusion, this PR changes the parameter "space" to "space_type" for custom scoring.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 4 years ago

Codecov Report

Merging #232 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #232   +/-   ##
=========================================
  Coverage     78.51%   78.51%           
  Complexity      335      335           
=========================================
  Files            53       53           
  Lines          1308     1308           
  Branches        121      121           
=========================================
  Hits           1027     1027           
  Misses          228      228           
  Partials         53       53
Impacted Files Coverage Δ Complexity Δ
...search/knn/plugin/script/KNNVectorScoreScript.java 77.77% <100.00%> (ø) 5.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3199583...37f3b1c. Read the comment docs.