search

opendistro-for-elasticsearch / k-NN

🆕 A machine learning plugin which supports an approximate k-NN search algorithm for Open Distro.
https://opendistro.github.io/
Apache License 2.0
277 stars 55 forks source link

Upgrade commons-beanutils #297

Closed vamshin closed 3 years ago

vamshin commented 3 years ago

Issue #, if available: https://github.com/opendistro-for-elasticsearch/k-NN/issues/269

Description of changes: commons-beanutils:commons-beanutils:1.9.3 is coming from com.puppycrawl.tools:checkstyle:8.20. Added 'com.puppycrawl.tools:checkstyle:8.24' dependency. Also, added checkstyle.xml

Post update

./gradlew dependencies | grep commons-beanutils
     +--- commons-beanutils:commons-beanutils:1.9.4

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 3 years ago

Codecov Report

Merging #297 (1953232) into master (aa5d1d4) will increase coverage by 0.06%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #297      +/-   ##
============================================
+ Coverage     80.44%   80.51%   +0.06%     
- Complexity      387      388       +1     
============================================
  Files            62       62              
  Lines          1468     1468              
  Branches        130      130              
============================================
+ Hits           1181     1182       +1     
+ Misses          240      239       -1     
  Partials         47       47
Impacted Files Coverage Δ Complexity Δ
...opendistroforelasticsearch/knn/index/KNNQuery.java 77.77% <0.00%> (+5.55%) 8.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aa5d1d4...1953232. Read the comment docs.

vamshin commented 3 years ago

Why do we need to add checkstyle.xml to upgrade commons-beanutils?

Was referring Performance Analyzer plugin https://github.com/opendistro-for-elasticsearch/performance-analyzer/pull/248. With out adding the xml file, checkstyle fails at compilation.