VijayanB commented 3 years ago

Since user might be interested in accessing the values directly, allow getValue method. To use these in a script, leave out the get prefix and use value as a member variable.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 3 years ago

Codecov Report

Merging #339 (889adb7) into main (12677da) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #339   +/-   ##
=========================================
  Coverage     81.10%   81.10%           
  Complexity      406      406           
=========================================
  Files            62       62           
  Lines          1535     1535           
  Branches        141      141           
=========================================
  Hits           1245     1245           
  Misses          241      241           
  Partials         49       49

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 12677da...889adb7. Read the comment docs.

VijayanB commented 3 years ago

We will also need to update documentation with this change.

We will be releasing this feature in next release. I will create a task to make sure it is not slipped out.

opendistro-for-elasticsearch / k-NN

Expose getValue method from KNNScriptDocValues #339

Codecov Report