Closed zhongnansu closed 3 years ago
Merging #313 (3d518fb) into dev (1a5b871) will increase coverage by
0.07%
. The diff coverage is88.88%
.
@@ Coverage Diff @@
## dev #313 +/- ##
============================================
+ Coverage 64.16% 64.24% +0.07%
Complexity 291 291
============================================
Files 100 100
Lines 4044 4047 +3
Branches 614 613 -1
============================================
+ Hits 2595 2600 +5
+ Misses 1288 1287 -1
+ Partials 161 160 -1
Flag | Coverage Δ | Complexity Δ | |
---|---|---|---|
Kibana-reports | 77.82% <88.88%> (+0.14%) |
0.00 <0.00> (ø) |
|
reports-scheduler | 53.28% <ø> (ø) |
0.00 <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
kibana-reports/server/routes/utils/constants.ts | 100.00% <ø> (ø) |
0.00 <0.00> (ø) |
|
...r/routes/utils/visual_report/visualReportHelper.ts | 83.92% <ø> (ø) |
0.00 <0.00> (ø) |
|
...orts/server/routes/utils/converters/backendToUi.ts | 79.04% <83.33%> (+2.12%) |
0.00 <0.00> (ø) |
|
kibana-reports/server/utils/validationHelper.ts | 90.00% <100.00%> (+0.81%) |
0.00 <0.00> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1a5b871...3d518fb. Read the comment docs.
Issue #, if available:
98
This is the most reported issue so far. Users are not able to generate any report if they have customized Kibana sever setting(host, sever base path, port), or enable TLS.
Server config is set in kibana.yml
Description of changes:
localhost:5601
when building the complete urlserverInfo
(which containsport
,host
,protocol
), andserver.basePath
and pass them through route handler for validating the input url, compose complete url.ignoreHttpsError: true
to support TLS-enabled kibana server https://github.com/puppeteer/puppeteer/blob/main/docs/api.md#puppeteerlaunchoptionsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.