search

opendistro-for-elasticsearch / kibana-reports

Kibana Reports
https://opendistro.github.io/
39 stars 31 forks source link

Please review and apply the changes that fix reporting plugin issue. Ignore custom commented areas. #314

Closed logstail closed 3 years ago

logstail commented 3 years ago

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 3 years ago

Codecov Report

Merging #314 (748e938) into dev (76aec0b) will not change coverage. The diff coverage is 77.30%.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev     #314   +/-   ##
=========================================
  Coverage     64.24%   64.24%           
  Complexity      291      291           
=========================================
  Files           100      100           
  Lines          4047     4047           
  Branches        613      613           
=========================================
  Hits           2600     2600           
  Misses         1287     1287           
  Partials        160      160
Flag Coverage Δ Complexity Δ
Kibana-reports 77.82% <77.30%> (ø) 0.00 <0.00> (ø)
reports-scheduler 53.28% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
server/routes/utils/constants.ts 100.00% <ø> (ø) 0.00 <0.00> (?)
server/routes/utils/converters/backendToUi.ts 79.04% <ø> (ø) 0.00 <0.00> (?)
server/routes/utils/converters/uiToBackend.ts 83.63% <ø> (ø) 0.00 <0.00> (?)
server/routes/utils/dataReportHelpers.ts 59.43% <ø> (ø) 0.00 <0.00> (?)
server/routes/utils/helpers.ts 50.00% <ø> (ø) 0.00 <0.00> (?)
server/routes/utils/savedSearchReportHelper.ts 98.78% <ø> (ø) 0.00 <0.00> (?)
...r/routes/utils/visual_report/visualReportHelper.ts 83.92% <ø> (ø) 0.00 <0.00> (?)
server/utils/validationHelper.ts 90.00% <ø> (ø) 0.00 <0.00> (?)
test/httpMockClient.js 80.00% <ø> (ø) 0.00 <0.00> (?)
test/propsMock.js 100.00% <ø> (ø) 0.00 <0.00> (?)
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76aec0b...748e938. Read the comment docs.

zhongnansu commented 3 years ago

Hi, thx for your PR. I saw there are 200 files changed, which doesn't make sense. Most of the files are actually unchanged, maybe you changed the directory when submmiting the PR. Could you re-submit the PR? It's really hard for us the review file by file and find the difference by ourself. Please refer to other old PRs for reference.

Also, please add the related issue and the changes you made to the desciption. It's better we follow some standards, so that people can easily understand the purpose of this PR.

Thank, Zhongnan Su

zhongnansu commented 3 years ago

Pleaes fix the PR title, make it descriptive of the change or the issue your PR will fix.

anirudha commented 3 years ago

please re-open the PR if you have more questions, we verified the issue was fixed in 1.13, closing this for now