search

opendistro-for-elasticsearch / kibana-reports

Kibana Reports
https://opendistro.github.io/
39 stars 31 forks source link

Add cypress as devdependencies #316

Closed joshuali925 closed 3 years ago

joshuali925 commented 3 years ago

Issue #, if available:

Description of changes: Looks like reporting was using Cypress executable from x-pack, which won't work on kibana-oss. Adding separate cypress dependency to reporting

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 3 years ago

Codecov Report

Merging #316 (a4bd7fc) into dev (76aec0b) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev     #316   +/-   ##
=========================================
  Coverage     64.24%   64.24%           
  Complexity      291      291           
=========================================
  Files           100      100           
  Lines          4047     4047           
  Branches        613      613           
=========================================
  Hits           2600     2600           
  Misses         1287     1287           
  Partials        160      160
Flag Coverage Δ Complexity Δ
Kibana-reports 77.82% <ø> (ø) 0.00 <ø> (ø)
reports-scheduler 53.28% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76aec0b...a4bd7fc. Read the comment docs.