zhongnansu commented 3 years ago

Issue #, if available:

Description of changes:

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

codecov[bot] commented 3 years ago

Codecov Report

Merging #323 (c28423f) into dev (d67beac) will decrease coverage by 0.18%. The diff coverage is 27.77%.

@@             Coverage Diff              @@
##                dev     #323      +/-   ##
============================================
- Coverage     64.26%   64.07%   -0.19%     
  Complexity      291      291              
============================================
  Files           100      100              
  Lines          4049     4064      +15     
  Branches        613      618       +5     
============================================
+ Hits           2602     2604       +2     
- Misses         1287     1300      +13     
  Partials        160      160

Flag	Coverage Δ	Complexity Δ
Kibana-reports	`77.31% <27.77%> (-0.54%)`	`0.00 <0.00> (ø)`
reports-scheduler	`53.28% <ø> (ø)`	`0.00 <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
kibana-reports/server/model/backendModel.ts	`100.00% <ø> (ø)`	`0.00 <0.00> (ø)`
...orts/server/routes/utils/converters/backendToUi.ts	`70.83% <23.52%> (-8.22%)`	`0.00 <0.00> (ø)`
kibana-reports/server/utils/validationHelper.ts	`90.00% <100.00%> (ø)`	`0.00 <0.00> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d67beac...b719177. Read the comment docs.

zhongnansu commented 3 years ago

will fix the coverage issue in future PRs

opendistro-for-elasticsearch / kibana-reports

add security_tenant info into url #323

Codecov Report