opendistro-for-elasticsearch / kibana-reports

Kibana Reports
https://opendistro.github.io/
39 stars 31 forks source link

add global tenant for report definition urls #324

Closed zhongnansu closed 3 years ago

zhongnansu commented 3 years ago

Issue #, if available: on-demand report definition still renders the tenant panel Description of changes: add condtion to check global tenant and add to url

TODO:

  1. remove the old fix where we add the key-value pair to browser loacal storage
  2. See if we can get rid of the addTenantToUrl logic from UI side. Only using the tenant info from ES backend.
  3. Currently there's no way to distinguish global tenant and non-security from tenant field returned by backend. As they both are empty string.

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

codecov[bot] commented 3 years ago

Codecov Report

Merging #324 (f5cd6b7) into dev (9a0534d) will decrease coverage by 0.03%. The diff coverage is 25.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #324      +/-   ##
============================================
- Coverage     64.07%   64.04%   -0.04%     
  Complexity      291      291              
============================================
  Files           100      100              
  Lines          4064     4066       +2     
  Branches        618      619       +1     
============================================
  Hits           2604     2604              
- Misses         1300     1302       +2     
  Partials        160      160              
Flag Coverage Δ Complexity Δ
Kibana-reports 77.23% <25.00%> (-0.09%) 0.00 <0.00> (ø)
reports-scheduler 53.28% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...orts/server/routes/utils/converters/backendToUi.ts 69.67% <25.00%> (-1.17%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9a0534d...f5cd6b7. Read the comment docs.