Closed ccottam closed 3 years ago
Merging #329 (544c217) into dev (fb3cdf8) will increase coverage by
0.08%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## dev #329 +/- ##
============================================
+ Coverage 64.04% 64.12% +0.08%
Complexity 291 291
============================================
Files 100 100
Lines 4066 4081 +15
Branches 619 623 +4
============================================
+ Hits 2604 2617 +13
- Misses 1302 1304 +2
Partials 160 160
Flag | Coverage Δ | Complexity Δ | |
---|---|---|---|
Kibana-reports | 77.30% <ø> (+0.07%) |
0.00 <ø> (ø) |
|
reports-scheduler | 53.28% <ø> (ø) |
0.00 <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
kibana-reports/server/routes/utils/constants.ts | 100.00% <ø> (ø) |
0.00 <0.00> (ø) |
|
...r/routes/utils/visual_report/visualReportHelper.ts | 84.93% <ø> (+0.44%) |
0.00 <0.00> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fb3cdf8...544c217. Read the comment docs.
@zhongnansu @joshuali925 Is it possible to forward all the attributes in the request to headless chrome? do we have any specified reason that only forward the selected attributes?
@zhongnansu @joshuali925 Is it possible to forward all the attributes in the request to headless chrome? do we have any specified reason that only forward the selected attributes?
Yes I think we can forward all attibutes to chrome. At that time, we were just thinking to do the minimum change to meet the requirements for getting report with FGAC.
Issue #, if available: https://github.com/opendistro-for-elasticsearch/kibana-reports/issues/328
Description of changes:
Passing the x-proxy-user,x-forwarded-for and x-proxy-roles headers though to puppeteer if they exist.
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.