search

opendistro-for-elasticsearch / opendistro-build

🧰 Open Distro Build Scripts
https://opendistro.github.io/
Apache License 2.0
344 stars 175 forks source link

Hook up integration test for Alerting Kibana plugin #600

Closed tlfeng closed 3 years ago

tlfeng commented 3 years ago

Request adding integration test for Alerting Kibana plugin to the build workflow with and without security

Assumption: With security: Elasticsearch is running at http://localhost:9200, Kibana is running at http://localhost:5601 Without security: Elasticsearch is running at https://localhost:9200, Kibana is running at http://localhost:5601

Step to run the test:

  1. Start Elasticsearch server with Alerting plugin
  2. Start Kibana server with Alerting Kibana plugin
  3. (Wait for enough time to make sure Kibana server fully started)
  4. In the plugin directory (kibana/plugins/alerting-kibana-plugin), run command in below to start the Cypress test

With security: yarn run cypress run --env security_enabled=true WIthout security: yarn run cypress run

A successful workflow run in Alerting Kibana plugin repo, without security enabled: https://github.com/opendistro-for-elasticsearch/alerting-kibana-plugin/actions/runs/489045146 (A test failure is expected when running against Alerting Kibana plugin v1.12.0.2) The PR to support running Cypress test in ODFE cluster with security enabled for Alerting Kibana plugin: https://github.com/opendistro-for-elasticsearch/alerting-kibana-plugin/pull/235

gaiksaya commented 3 years ago

Hi @tlfeng,

I am working on this issue. However while doing so looks like the the non security tests are working well but for security test it is failing. I am testing with 1.13.0. Please find the below test runs for alerting kibana plugin with security: https://github.com/opendistro-for-elasticsearch/opendistro-build/runs/1931065268?check_suite_focus=true https://github.com/opendistro-for-elasticsearch/opendistro-build/runs/1931401599?check_suite_focus=true

Please let us know if you have any update to resolve it. Till then I'll work on adding non-security tests. Thanks!

tlfeng commented 3 years ago

Thank you for informing me the result of the workflow runs. Let me take a loot at the failures.

tlfeng commented 3 years ago

Seems the test failure is caused by this modal appears on the top, I'm going to find solution for it.

select your tenant - modal 7 10 2
gaiksaya commented 3 years ago

Sure @tlfeng . Let me know when you fix it or have an update. Thanks!

bbarani commented 3 years ago

@tlfeng , Any update on this issue?

tlfeng commented 3 years ago

Hi @bbarani, sorry that I haven't took much time on finding the solution. I will try to find the fix in this week, including checking how other plugins deal with it.

tlfeng commented 3 years ago

Hi @gaiksaya, Sorry for the delay. The fix of the test failure in ODFE 1.13 was merged, and please help me verify the test result when you have time. Thank you!

gaiksaya commented 3 years ago

Hi @tlfeng ,

Thank you for fixing it. I have created the PR to add the tests in our workflows.

tlfeng commented 3 years ago

Thank you for your rapid action! 👍👍 @gaiksaya