search

opendistro-for-elasticsearch / opendistro-build

🧰 Open Distro Build Scripts
https://opendistro.github.io/
Apache License 2.0
344 stars 175 forks source link

Persistlabels #669

Closed Vastyjoy closed 3 years ago

Vastyjoy commented 3 years ago

To work with sbercloud, you need to add labels to the VPC

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

sreekarjami commented 3 years ago

Hi @Vastyjoy , Can you please inform more on why this change is needed. I think the persistence labels can be used on the custom need of a user, based on their environment. This change is an enhancement but might not be needed by all, please provide more information. Also please attach test results for further review.

Thanks for contribution.

bbarani commented 3 years ago

@Vastyjoy , Can you please check the above question and provide your comments?

sreekarjami commented 3 years ago

Hi @Vastyjoy, I am closing this PR as there was no response to the query. Please feel free to reopen the PR or submit new one with the requested information and test results.

Thanks for your contribution.