search

opendistro-for-elasticsearch / opendistro-build

🧰 Open Distro Build Scripts
https://opendistro.github.io/
Apache License 2.0
344 stars 175 forks source link

helm: Use networking.k8s.io/v1beta1 API version for ingresses #684

Closed OlleLarsson closed 3 years ago

OlleLarsson commented 3 years ago

Issue #, if available: None

Description of changes: Updates the API version for both the Kibana and Elasticsearch ingresses.

From https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/ The v1.22 release will stop serving the following deprecated API versions in favor of newer and more stable API versions:

This is just a small bump as the API version is already deprecated in v1.19+

Warning: networking.k8s.io/v1beta1 Ingress is deprecated in v1.19+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress

but I guess it's smart to do these changes in smaller steps.

Test Results:

Note: If this PR is related to Helm, please also update the README for related documentation changes. Thanks. https://github.com/opendistro-for-elasticsearch/opendistro-build/blob/master/helm/README.md

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on signing off your commits, please check here.

peterzhuamazon commented 3 years ago

Hi @OlleLarsson, thanks for making this changes. Could you provide any test results on this. And will this change break the existing functionalities of our Helm Charts?

Thanks.

OlleLarsson commented 3 years ago

Hi @OlleLarsson, thanks for making this changes. Could you provide any test results on this. And will this change break the existing functionalities of our Helm Charts?

Thanks.

It shouldn't break anything, but give me a couple of days and I'll try to squeeze in some time to test properly :)

peterzhuamazon commented 3 years ago

Hi @OlleLarsson, thanks for making this changes. Could you provide any test results on this. And will this change break the existing functionalities of our Helm Charts? Thanks.

It shouldn't break anything, but give me a couple of days and I'll try to squeeze in some time to test properly :)

Hi @OlleLarsson please let us know once you have the test done. And post the results of the tests.

Thanks.

peterzhuamazon commented 3 years ago

Hi @OlleLarsson it has been 25 days since your last comment. We will close this PR for now.

Please feel free to reopen it once you have any updates.

Thanks.