search

opendistro-for-elasticsearch / opendistro-build

🧰 Open Distro Build Scripts
https://opendistro.github.io/
Apache License 2.0
344 stars 175 forks source link

Fix K8S probe should be object instead of list #762

Closed alantang888 closed 3 years ago

alantang888 commented 3 years ago

Description of changes: Fix K8S probe should be object instead of list. That cause coalesce.go:199: warning: destination for readinessProbe is a table. Ignoring non-table value [] if override those values.

Also put correct default value of livenessProbe on README.md

Test Results: Helm lint OK, just have rbac.authorization.k8s.io/v1beta1 deprecated warning. And I'm not sure should I fix it at the moment. Also work with my deployment

Note: If this PR is related to Helm, please also update the README for related documentation changes. Thanks. https://github.com/opendistro-for-elasticsearch/opendistro-build/blob/master/helm/README.md

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on signing off your commits, please check here.

peterzhuamazon commented 3 years ago

Hi @alantang888 we have moved to OpenSearch (opensearch.org) And we just merged the 1st version of Helm there opensearch-project/opensearch-devops#4 Could you close this PR and migrate there? Thanks.

alantang888 commented 3 years ago

Sure, thanks for update.