opendistro-for-elasticsearch / opendistro-build

🧰 Open Distro Build Scripts
https://opendistro.github.io/
Apache License 2.0
344 stars 175 forks source link

Master podAntiAffinity example differs from client and data examples in helm/opendistro-es/values.yaml #776

Open dale-c-anderson opened 3 years ago

dale-c-anderson commented 3 years ago

Describe the bug I don't know enough about podAntiAffinity to be able to tell if this is actually a bug; it might just be a clarification issue.

All I know is that one of these things:

Is the master example different on purpose? It appears so, as all 3 podAntiAffinity blocks were originally added by @ashwinkumar12345 in the same commit and then later changed to example code instead, I just don't know the reasonig for it.

The kubernetes docs shows a weighted podAntiAffinity example, and I know there are other ways to do it. I just don't know which is the best way.

If someone more knowledgeable than me can tell me one way or the other, I'd be happy to submit a PR.