search

opendocument-app / OpenDocument.core

C++ library that translates office documents to HTML
GNU General Public License v3.0
24 stars 9 forks source link

search integration #198

Closed TomTasche closed 4 years ago

TomTasche commented 4 years ago

addresses https://github.com/opendocument-app/OpenDocument.core/issues/115

(only a draft because I want your feedback on the script setup, but still need to fix a potential bug with the actual Javascript)

andiwand commented 4 years ago

did you apply babel to the resource files?

TomTasche commented 4 years ago

did you apply babel to the resource files?

yes, the babel setup is part of this branch now

andiwand commented 4 years ago

do you think it should become part of the build process to babel and automatically place the output into the source files?

TomTasche commented 4 years ago

do you think it should become part of the build process to babel and automatically place the output into the source files?

it should be, but it sounds like going down a rabbit hole... the current approach is fine in my opinion as long as we almost never change javascript

andiwand commented 4 years ago

agreed. especially because the node installation can be painful. docker might help here but then we have another problem 😄

TomTasche commented 4 years ago

UI on iOS is ready. is this good to merge for you @andiwand ? https://github.com/opendocument-app/OpenDocument.ios/pull/57