opendocument-app / OpenDocument.droid

It's Android's first OpenOffice Document Reader!
https://opendocument.app/
Other
266 stars 36 forks source link

Upgrade pdf2htmlEX-Android to 0.18.25 to workaround issue #348 #361

Closed ViliusSutkus89 closed 3 months ago

TomTasche commented 3 months ago

I guess I should have tested that before merging: the problematic PDFs I sent you open completely empty for me when testing inside the app :thinking: @ViliusSutkus89

ViliusSutkus89 commented 3 months ago

That sounds bad. I've tested the change on the library, then tested my own downstream app (Documenter) with the new library version and it was OK. Let me see what's what

ViliusSutkus89 commented 3 months ago

Just did a clean build of odr.droid@main, all three documents look nice. I mean, font could look better, boldness is gone, but all the text is visible. Could you do a clean build to verify?

TomTasche commented 3 months ago

I definitely did, but will try again. Sorry!

TomTasche commented 3 months ago

I had to uninstall the app first, then it worked. I'm hoping that's just some Android Studio annoyance. All good, thanks! :+1: