opendp / dp-wizard

Web application that makes data releases that satisfy differential privacy using the OpenDP Library
MIT License
0 stars 1 forks source link

Hide weight if only one column selected #170

Closed mccalluc closed 3 days ago

mccalluc commented 5 days ago

Shiny doesn't seem to support disabling select controls. Not in the docs, and just adding a kwarg doesn't work. Adding a note after the control follows the pattern we have with disabled buttons. For both of these styling it as a bootstrap alert might be appropriate.

For reviewer:

On the whole I think this is a good change, but I'm not totally confident about it. Feedback welcome.


Update: Instead of adding a message, just use a hidden div when there is only one column selected. PR retitled.

mccalluc commented 4 days ago

@ekraffmiller : Good thoughts. I tend to shy away from controls that are disabled based on some other criterion. We've all been in the place where we can see the option we need, and it's so close, but it's grey for no apparent reason.

I'm going to try a new PR, but instead of adding a message, just wrapping the control in a hidden div. Stay tuned...