Closed mccalluc closed 2 weeks ago
I'm going to say this much is ready for review. There are more references to --features
but I'll address that in a separate PR, to keep this much from getting muddled.
R/opendp/src/Makevars.in:
30: @BEFORE_CARGO_BUILD@ cargo build --manifest-path rust/Cargo.toml --color always --release --jobs 2 --offline --features @RUST_FEATURES@; \
R/opendp/src/Makevars.win.in:
34: @BEFORE_CARGO_BUILD@ cargo build --manifest-path rust/Cargo.toml --target=$(TARGET) --color always --release --jobs 2 --offline --features @RUST_FEATURES@; \
tools/rust_build.sh:
86: CMD+=(--manifest-path=rust/Cargo.toml --features="$FEATURES")
CI failure in r-tests: Also saw the same problem on main
and filed an issue:
The last commit here only touched tasks.json
, so the r-tests problem is non-deterministic, even though it seems to be related to the build. Exciting.
Rerunning the failing test.
WIP:
tasks.json
Makevars*
andrust_build.sh
parameterize--features
... Maybe we still want the flexibility there?