Is `--all-features` too much? Clean up remainining `--features`?

opendp / opendp

The core library of differential privacy algorithms powering the OpenDP Project.

https://opendp.org

MIT License

284 stars 46 forks source link

Closed mccalluc closed 2 weeks ago

mccalluc commented 2 weeks ago

This could be split, but it's one theme:

Is --all-features fine to use for the build? If test code is being compiled into our binary, that's not ideal, but maybe something else prevents that? Is there anything beside tests that we wouldn't want?
There are still a few references to --features in the build scripts. Are they safe to remove? I'll probably just try and see what happens.
follow up to #1526

mccalluc commented 2 weeks ago

Last PR went a little too far, but Mike will reestablish that in smoke-test. The other references to --features should remain.