search

opendr-eu / opendr

A modular, open and non-proprietary toolkit for core robotic functionalities by harnessing deep learning
Apache License 2.0
615 stars 95 forks source link

ROS1 final updates #364

Closed tsampazk closed 1 year ago

tsampazk commented 1 year ago

This PR should conclude the fixes for the ROS1 workspace and packages of OpenDR.

  1. Applied some fixes i missed on the previous PR #357
  2. Renamed all ROS1 package directories to include "opendr_" prefix in their names, e.g. "perception"->"opendr_perception" as suggested
  3. Renamed references that i could find to the package names in their corresponding package.xml, CMakeLists.txt, etc.
  4. READMEs for opendr_perception package will be updated in a separate PR (#316) to include changes from this PR
  5. Added "_node" in all node script filenames, to match those in ROS2 (#256). This makes it obvious that these .py files are the ROS nodes
  6. Renamed the ros bridge doc file in the documentation to match the package name
  7. Found an unrelated issue in /dependencies/pip_requirements.txt, where the old version of python was used and brought it up to speed with the main installation script that installs torch==1.9.0.

I added a comment here in setup.py of ros bridge, so it shows up in the review. I don't know whether this file is used but the name of the package there seems wrong.

closes #209, closes #275, closes #303, closes #305, closes #309

tsampazk commented 1 year ago

Added some minor link fixes, etc., in the docs.

Renamed the bridge directories etc to opendr_bridge instead of opendr_ros_bridge, as the name of the actual package used is opendr_bridge. I realised this from Niko's comment in his review.

I kept the docs file name as opendr-ros-bridge.md to make it clear among all other docs that this bridge is related to ros, but fixed the package name referred within.

ad-daniel commented 1 year ago

Renamed the bridge directories etc to opendr_bridge instead of opendr_ros_bridge, as the name of the actual package used is opendr_bridge. I realised this from Niko's comment in his review.

so no distinction will be made between ROS and ROS2?

tsampazk commented 1 year ago

Renamed the bridge directories etc to opendr_bridge instead of opendr_ros_bridge, as the name of the actual package used is opendr_bridge. I realised this from Niko's comment in his review.

so no distinction will be made between ROS and ROS2?

Do you think that it is needed? Do we expect users to run ROS and ROS2 in parallel and import messages while having sourced both workspaces? I could rename the ROS2 package to opendr_bridge_2 similar to how the workspace is named.