search

opendr-eu / opendr

A modular, open and non-proprietary toolkit for core robotic functionalities by harnessing deep learning
Apache License 2.0
621 stars 95 forks source link

ROS2 Node for EfficientLPS #404

Closed aselimc closed 1 year ago

aselimc commented 1 year ago

Hi,

This PR adds EfficientLPS ROS2 nodes. It should be merged after the #359. It simply adds the same functionality as we added for ROS nodes but this is for ROS2.

aselimc commented 1 year ago

Thank you for the new node! We are missing a ROS2 dependency for the new messages used, i added it in our build file.

When running the point cloud publisher node without the -t flag it produces the following error:

opendr_perception/point_cloud_2_publisher_node.py", line 65, in start
    point_cloud = self.dataset[i % len(self.dataset)][0]
AttributeError: 'PointCloud2DatasetNode' object has no attribute 'dataset'

which is not particularly useful, instead of getting the error in line 80, similar to the ROS1 node. Could you please look into this so it properly prints the correct error message in case a dataset is not provided and the flag -t not used?

Sorry for this, I will fix it probably later today (studying to exams 😄). I was wondering that the error message in line 80 is still produced before AttributeError right?

tsampazk commented 1 year ago

Sorry for this, I will fix it probably later today (studying to exams smile). I was wondering that the error message in line 80 is still produced before AttributeError right?

No problem, i think it doesn't print at all :confused:

aselimc commented 1 year ago

Sorry for this, I will fix it probably later today (studying to exams smile). I was wondering that the error message in line 80 is still produced before AttributeError right?

No problem, i think it doesn't print at all 😕

This should be addressed now. Thanks for noticing this 😄