search

opendr-eu / opendr

A modular, open and non-proprietary toolkit for core robotic functionalities by harnessing deep learning
Apache License 2.0
614 stars 95 forks source link

High Resolution Pose Estimation webcam demo #409

Closed mthodoris closed 1 year ago

mthodoris commented 1 year ago

Thank you for the new demo, it is really useful for comparing the two methods.

I have some mostly minor comments on the code itself. I tested the demo locally and noticed that it ran ok for webcam, but when i used an ip camera via the android app DroidCam, providing high resolution input, i got two issues:

1. The images came out with a distorted aspect ratio, in my case they appeared wider

2. There was a significant delay similar to what we had in ROS #275, and as far as i could tell it got worse and worse while it was running. To clarify a bit, i had a smooth framerate a delay between when e.g. a hand move was made and when i saw the move on the output.

thank you @tsampazk for your review, I will check your comments on Ip mode and I would update it properly