Closed aselimc closed 11 months ago
We have a quick question here to the repository owners. We are using g2o, for optimization; however, there is no setup.py for it. Thus, the installation process is a not straightforward. Here, should I try to write a setup.py file to do this installation automatically, or leave it out and just write how it should be done in README, or what would be your suggestion?
Thanks in advance
We have a quick question here to the repository owners. We are using g2o, for optimization; however, there is no setup.py for it. Thus, the installation process is a not straightforward. Here, should I try to write a setup.py file to do this installation automatically, or leave it out and just write how it should be done in README, or what would be your suggestion?
Thanks in advance
Yes, you should write a setup.py
file.
We should aim at having a script that automatically installs all the tool's dependencies.
@stefaniapedrazzi Hello, I have fixed the setup issue, and now it installs everything automatically. Can you please review the code?
Thanks
Hi, following up on the email after the meeting. This PR has been ready for review since the last commit.
Thank you! Can you please update the dependencies to make sure that follow the rest of the toolkit. Currently we are using
torch==1.13.1
torchvision==0.14.1
You are specifying torch==1.9.0
, but since we are having another version only one of the two is going to be installed, either breaking this tool or some of the rest of the tools.
Also, when not absolutely necessary, please consider using less strict versions, allowing for updates, i.e.,>=
instead of ==
in dependencies.
Hello @passalis , we have addressed everything. Please have a look at the draft again, thank you!
@passalis @omichel Thank you for the approval!
Hello everyone,
This PR aims to add new SLAM tool Continual SLAM, original repository can be found here.