Added unzip installation as base ubuntu dependency and tool tests fixes

opendr-eu / opendr

A modular, open and non-proprietary toolkit for core robotic functionalities by harnessing deep learning

Apache License 2.0

619 stars 95 forks source link

Added unzip installation as base ubuntu dependency and tool tests fixes #454

Closed tsampazk closed 1 year ago

tsampazk commented 1 year ago

Fixes:

Possible fix #453.
Replaced bcolz with bcolz-zipline to fix broken installation
In tests_suite.yml fixed a call for pip install /tests/sources/requirements.txt which is an empty file to pip install /tests/requirements.txt which seems to be the correct one
More strict pillow version, added <10.0.0, which breaks calls to LINEAR from detectron2 (which itself sits at an older version, newer versions have fixed this)
Changed ultralytics requirement to ultralytics-yolov5 requirement in object_detection_2d requirements file

Created the branch off master since it seems develop and master are not yet synchronized after latest release, let me know if this needs changing.

passalis commented 1 year ago

I replaced bcolz with bcolz-zipline, which made the situation much better, but I still see some failures in yolov5 (library not found), nms (couldn't download pretrained model'), and single demo grasp (an error probably due to PIL attribute missing).

passalis commented 1 year ago

@vivinousi @charsyme @amirmehman21 Could you please check the failures? Thank you!

charsyme commented 1 year ago

@passalis I changed/renamed some files on FTP server regarding object_detection_2d/nms tools. Once #442 will be merged, these specific failures will be dissmised.

tsampazk commented 1 year ago

This thread seems to have some information regarding the "AttributeError: module 'PIL.Image' has no attribute 'LINEAR'" of single demo grasp. I am not sure whether we can indeed update detectron2 and what other issues it might bring with embedded devices etc. @Pavlos-Tosidis any thoughts?

Maybe we can force an older version of PIL that uses the deprecated "LINEAR"?

Pavlos-Tosidis commented 1 year ago

TX2 is not supported by NVIDIA anymore, which means the JetPack for it is an older version which does not support Python3.8, and that causes many problems with various updated dependencies , like Pytorch. So the update on the embedded devices docker images are being implemented mostly manually, with some of the tools not being able to run. To conclude, the update on the toolkit for Desktop use won't break anything on the current images of the embedded devices, but some of the tools being added might not work.

tsampazk commented 1 year ago

Alright after some messing about, all tests (apart from the nms tool which is fixed in another PR) pass successfully. As soon as everything finishes im going to convert this to ready for review to go forward.

I also got some ideas about improving the workflows, i will test them in a subsequent PR.

tsampazk commented 1 year ago

@passalis I changed/renamed some files on FTP server regarding object_detection_2d/nms tools. Once #442 will be merged, these specific failures will be dissmised.

Nms is expected to fail due to changed filenames in FTP, i will go ahead and merge this.