search

opendr-eu / opendr

A modular, open and non-proprietary toolkit for core robotic functionalities by harnessing deep learning
Apache License 2.0
619 stars 95 forks source link

Active_demo and some minor bug fixes on FaceRecognition #459

Closed Pavlos-Tosidis closed 10 months ago

Pavlos-Tosidis commented 1 year ago

Changed Face Recognition inference return. Now class is 0/1 if not found/found Added feature_extraction method to get access to features from a face image Added active_demo in which features in database get updated with new features of the same person.

tsampazk commented 1 year ago

This is pretty weird, the ~PEP8 tests fail~ at unrelated files from other tools with deprecation warnings for invalid escape characters in regex strings. Maybe these files were excluded from tests earlier, as they are in /algorithm directories.

Edit: these are warnings, they don't fail the tests :smile:

thomaspeyrucain commented 1 year ago

Hello @Pavlos-Tosidis,

I am testing the tool and sometimes I get this error:

[ERROR] [1697016110.932028]: bad callback: <bound method FaceRecognitionNode.callback of <__main__.FaceRecognitionNode object at 0x7fcdc1274550>>
Traceback (most recent call last):
  File "/opt/ros/noetic/lib/python3/dist-packages/rospy/topics.py", line 750, in _invoke_callback
    cb(msg)
  File "/home/thomaspeyrucain/Desktop/OpenDR/opendr_pal_use_case/projects/opendr_ws/src/opendr_perception/scripts/face_recognition_node.py", line 180, in callback
    self.recognizer.database[result.description].append(features_to_compare)
AttributeError: 'Tensor' object has no attribute 'append'
passalis commented 11 months ago

@Pavlos-Tosidis There seems to be pep8 errors still.

passalis commented 10 months ago

Thanks @Pavlos-Tosidis! Is this ready for review?

Pavlos-Tosidis commented 10 months ago

Yes this is ready to be reviewed