opendr-eu / opendr

A modular, open and non-proprietary toolkit for core robotic functionalities by harnessing deep learning
Apache License 2.0
611 stars 94 forks source link

Adding prompt when transcribe with Whisper #462

Closed minhquoc0712 closed 9 months ago

minhquoc0712 commented 10 months ago
tsampazk commented 10 months ago

The tests on speech_transcription/vosk fail. It seems that the certificates of the url used to download vosk models have expired. I think it's this one which indeed gives out a warning of expired certificates when visiting from the browser. It seems they expired today:

Websites prove their identity via certificates, which are valid for a set time period. 
The certificate for alphacephei.com expired on 9/26/2023.

Error code: SEC_ERROR_EXPIRED_CERTIFICATE

Found a similar issue here from last year.

One quick fix would be to disable verification here by adding the verify=False argument. However, it still fails down the line on this one. Following a quick search, i couldn't find an easy way to disable verification on that one. @minhquoc0712 could you please take a look at potential fixes and maybe include them on this PR?

minhquoc0712 commented 9 months ago

@tsampazk , I run the test_voks.py, and it doesn't have any errors. I run it from my room's WiFi. Can you try again? Perhaps, Vosk developers made some fixes?

tsampazk commented 9 months ago

@minhquoc0712 thanks for testing, it seems that indeed they seem to have fixed the expired certificates. I will provide a review soon.