opendr-eu / opendr

A modular, open and non-proprietary toolkit for core robotic functionalities by harnessing deep learning
Apache License 2.0
611 stars 94 forks source link

Fixed simulation to run with Webots R2023b #477

Closed omichel closed 8 months ago

omichel commented 8 months ago

Fixed the agricultural simulation dataset generator so that it works with the latest version of Webots, namely, R2023b. The simulation however still displays a number of warning that were anterior to this PR and that should probably be addressed, although it seems to work as expected. Here here the log I am getting now on Webots (tested on Windows 11):

WARNING: The mass ratio between the heaviest solid ('Tractor "vehicle"' - mass = 1000 kg) and the lightest solid ('DEF LED_RIGHT LED' - mass = 0.0035 kg) is huge. This is a source of physics instabilities.
WARNING: Tractor "vehicle": heaviest solid
WARNING: Mavic2Pro "Mavic 2 PRO" > DEF LED_RIGHT LED: lightest solid
INFO: mavic2pro_patrol: Starting controller: python.exe -u mavic2pro_patrol.py
INFO: generate_robotti_obstacles_datasets: Starting controller: python.exe -u generate_robotti_obstacles_datasets.py
INFO: <generic>: Starting controller: "C:\Program Files\Webots\resources\projects\controllers\generic\generic.exe"
noon_cloudy_countryside
Mavic second: 1
Robotti second: 1
WARNING: The current physics step could not be computed correctly. Your world may be too complex. If this problem persists, try simplifying your bounding object(s), reducing the number of joints, or reducing WorldInfo.basicTimeStep.
Mavic second: 2
Robotti second: 2
WARNING: The current physics step could not be computed correctly. Your world may be too complex. If this problem persists, try simplifying your bounding object(s), reducing the number of joints, or reducing WorldInfo.basicTimeStep.
Mavic second: 3
Robotti second: 3

I also tested it with the latest nightly build of Webots R2023b-rev1 (from 9-11-2023) and it works well.

omichel commented 8 months ago

@halil93ibrahim: could please review this PR and approve it if resolves your problem?

halil93ibrahim commented 8 months ago

@halil93ibrahim: could please review this PR and approve it if resolves your problem?

I will do it.