opendreambox / enigma2-plugins

Python plug-ins for enigma2 (DreamOS)
https://dreambox.de/
Other
37 stars 49 forks source link

Output space-separated tags correctly #28

Closed wedebe closed 3 years ago

wedebe commented 3 years ago

Output space-separated tags correctly

This change outputs autotimer tags individually instead of providing a space-separated list which splits space-separated tags incorrectly.

is kept so as not to break existing consumers.
drecomx commented 3 years ago

From my point of view this change breaks timer display in WebInterface

wedebe commented 3 years ago

From my point of view this change breaks timer display in WebInterface

Hi @drecomx , could you get a screenshot/detailed description so I can investigate further, please?

drecomx commented 3 years ago

Ok when I see where you usally commit then it becomes obvious that you don't use DreamOS. This repository is for DreamOS only not for any Open* image.

dhwz commented 3 years ago

Exactly, means he forked the wrong git. Instead of the one which is used on OE-A Images.

wedebe commented 3 years ago

This change is to accommodate E2OpenPlugins OpenWebif's consumption of (all image versions of) AutoTimer tags.

https://github.com/oe-alliance/enigma2-plugins/issues/418

dhwz commented 3 years ago

So where is the relevance for DreamOS?

wedebe commented 3 years ago

If DreamOS doesn't use E2OpenPlugins OpenWebif, none.

dhwz commented 3 years ago

Good then we can close this pull request :-)