opendroneid / opendroneid-core-c

Open Drone ID Core C Library
Apache License 2.0
178 stars 64 forks source link

Share BT5 long range transmitter (nrf52840) #43

Closed DamyHao closed 2 years ago

DamyHao commented 3 years ago

Hi, This is my first open source contribution. I have a transmitter that emits in BT5 long range according to the RemoteID specification, using a nrf52840 dongle, and I want to share it with the community.

How do I proceed now? I create my repository and then it will be added to the opendroneid repositories?

Thanks for the help.

friissoren commented 3 years ago

Hi

That is very kind of you.

I can create the repository but we should agree on the name first. Any special preferences? I would suggest "transmit_nrf52840"?

What SW license would you be willing to share this code under? Apache-2.0?

@gabrielcox: Any comments?

Best regards, Søren

gabrielcox commented 3 years ago

How about "transmitter-nrf" (since it will likely be a good base for many NRF models).

Apache-2.0 would be great for a license choice.

friissoren commented 3 years ago

I created https://github.com/opendroneid/transmitter-nrf

Let me know if you have any problems uploading content there.

I took a leap of faith and added the Apache-2.0 license. If you are uncomfortable publishing your code under that license, please just let me know and we can change it.

friissoren commented 3 years ago

I re-read your original post and it suddenly occurred to me that you might have meant that you would like to have the repository under your own user name (https://github.com/DamyHao) and we would instead link to it from this repository?

If that was your intention, that is certainly possible also. Just let us know.

DamyHao commented 3 years ago

Hi, Sorry for not responding before. I need to clean the code and look how open source repository work. This week I have a lot of work to do (somehow related to remoteID) so I think I will upload it on Friday. The open drone repository is ok for me. Sorry for the inconveniences.

El dl., 30 d’ag. 2021, 8:31, friissoren @.***> va escriure:

I re-read your original post and it suddenly occurred to me that you might have meant that you would like to have the repository under your own user name (https://github.com/DamyHao) and we would instead link to it from this repository?

If that was your intention, that is certainly possible also. Just let us know.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/opendroneid/opendroneid-core-c/issues/43#issuecomment-908069300, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF57WNJ6ESQACQ4KVGXTRUDT7MQUVANCNFSM5C4KLVPQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

friissoren commented 3 years ago

No problem. Just take all the time you need.