search

opendroneid / opendroneid-core-c

Open Drone ID Core C Library
Apache License 2.0
170 stars 64 forks source link

Check authentication message length wrt to maximum number of pages #49

Closed cedric-papon closed 2 years ago

cedric-papon commented 2 years ago

Fix for #48

cedric-papon commented 2 years ago

Implemented your proposed changes, thanks.

Should we add "-Wextra" flag in the root CMakeLists.txt ?

BTW I also checked with cppcheck (1.90) and clang-tidy-10 for sanity.

friissoren commented 2 years ago

Yes, I definitely think it would be a good idea to add -Wextra to the compile flags. However, there are a few additional warnings in odid_test that should be handled then also. I can take a look at that.

friissoren commented 2 years ago

-Wextra flag now added. And a bunch of lint warnings fixed.

friissoren commented 2 years ago

-Wextra flag now added. And a bunch of lint warnings fixed.