search

opendroneid / opendroneid-core-c

Open Drone ID Core C Library
Apache License 2.0
178 stars 64 forks source link

BUG: encodeBasicIDMessage does not initialize reserved bytes #54

Closed lestofante closed 2 years ago

lestofante commented 2 years ago

ODID_BasicID_encoded end with 3 reserved bytes, but are not initialized. Other struct with reserved bytes, like ODID_OperatorID_encoded used by encodeOperatorIDMessage, get memset to 0.

I guess somewhere a unit test is also not properly checking all bytes generated, or is missing

friissoren commented 2 years ago

Nice catch. That is clearly inconsistently handled in different messages. Should be fixed now.