search

opendroneid / receiver-android

Example Android receiver application for unmanned aircraft Remote ID
Apache License 2.0
186 stars 61 forks source link

Added French to multi-language #59

Closed Tissy closed 2 years ago

Tissy commented 2 years ago

Being half French, I thought I would add my language translation contribution :)

gabrielcox commented 2 years ago

Wow! 2 languages within hours of each other. Is your PR with consideration that the Japanese PR with come through first? That would be ideal to minimize conflicts. It looks like both have similar changes to strings.xml. If you haven't already, please have a look at and analyze the Japanese PR to see how it may impact yours.

We really appreciate your contribution. This is great!

friissoren commented 2 years ago

Thanks. I am currently traveling. Please wait a few days and I can take a look at this. We need to figure out how to deal with the conflicts between this PR and PR #58.

Tissy commented 2 years ago

I did it off the back of the Japanese translation. Wonder if there is a simple way to perhaps add a menu function to select the required language?

gabrielcox commented 2 years ago

I think the Main Android Settings/Language settings can change it back and forth for testing. As I understand it, based on your locale setting, within the App, Android will use the language your device is set to if the language strings are there (as the ja and fr PRs add). The the language file is not there, it will use the "default" strings.xml.

friissoren commented 2 years ago

BTW: I tested Gabriel's suspicion that the app language will change with the main phone system language. I tried this on a virtual/emulator device in Android studio. When you change the system language in the settings menu, even an open instance of the app will change the displayed language, when you switch over to it. Very nice.

friissoren commented 2 years ago

Thanks. I have merged this now.

Some of those translations look rather long. You might at some point try to fire up the app and get a transmitter visible in the list, open the Info view and then check the layout of the detailed info view. That view is quite "busy" and might wrap the text strangely when the fields become too long.

Tissy commented 2 years ago

Yup, totally agree. I shall make some amendments :)