opendroneid / transmitter-linux

Example Open Drone ID Linux transmitter for Bluetooth and Wi-Fi.
Apache License 2.0
48 stars 26 forks source link

[Git] Use https or relative path for submodule urls #13

Closed MartinHerren closed 1 year ago

MartinHerren commented 1 year ago

Hello,

Wanting to try out transmitter-linux i cloned recursively this repo and the cloning failed on the sub modules.

The issue is that i used a computer of which i didn't authorize the ssh keys on github.

The simple fix is of course to add the public key to github.

As this is a public repo it would make sense to be able to clone it without a github account. So i replaced the sub module urls with https urls instead of ssh ones.

For the opendroneid-core-c module, as it is in the same repo, i used a relative path, this way

The hostapd and bluez urls work with anonymous ssh, so i could revert this part of the PR if you prefer.

Thanks for this nice project !

friissoren commented 1 year ago

Thanks. This makes sense. Consistency is always a good thing.